Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb-shared lagoon.type. #889

Merged
merged 5 commits into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@rtprio
Copy link
Contributor

rtprio commented Feb 7, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The service broker for mongodb permits one larger mongodb instance to serve the mongo needs of several projects at once.

Changelog Entry

Feature - add mongo-shared service type (#890)

Closing issues

closes #890
also closes VLAAN-19

rtprio added some commits Feb 7, 2019

@rtprio rtprio requested a review from Schnitzel Feb 7, 2019

@Schnitzel
Copy link
Member

Schnitzel left a comment

code looks good! can you please add:

  1. A changelog entry
  2. Also update the services types list https://lagoon.readthedocs.io/en/latest/using_lagoon/service_types/

@rtprio rtprio self-assigned this Feb 8, 2019

@rtprio

This comment has been minimized.

Copy link
Contributor Author

rtprio commented Feb 12, 2019

  1. A changelog entry
    I've updated this PR to follow the template.
  1. Also update the services types list https://lagoon.readthedocs.io/en/latest/using_lagoon/service_types/
    👌

@rtprio rtprio closed this Feb 12, 2019

@rtprio rtprio reopened this Feb 12, 2019

@rtprio

This comment has been minimized.

Copy link
Contributor Author

rtprio commented Feb 12, 2019

  1. A changelog entry
    I've updated this pr to follow the template
  2. Also update the services types list https://lagoon.readthedocs.io/en/latest/using_lagoon/service_types/
    done
@rtprio
Copy link
Contributor Author

rtprio left a comment

ok

@rtprio rtprio requested a review from twardnw Feb 12, 2019

@twardnw
Copy link
Member

twardnw left a comment

Thanks for getting these in

github ui is confusing...

I've already acknowledged the changes and github ui is 😕

Schnitzel added a commit that referenced this pull request Feb 26, 2019

@Schnitzel Schnitzel merged commit b9c879e into master Feb 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.