Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get job pod templates from DeploymentConfig instead of running Pods #899

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@rocketeerbkw
Copy link
Member

rocketeerbkw commented Feb 13, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Changelog entry has been written

The current task system uses existing openshift pods as a source for creating new openshift job pods. If the pods are idled, the task system will not find a running pod of the correct service and the openshiftjob service will bail out. This causes the task to not be able to run.

This PR changes to querying the openshift DeploymentConfigs instead of the pods, so a template can always be found (assuming an appropriate service exists for the project). Testing showed that pods created this way have the same config as if the template was copied from another pod.

Changelog Entry

Bugfix - Get job pod templates from DeploymentConfig instead of running Pods (#895)

Closing issues

closes #895

Schnitzel added a commit that referenced this pull request Feb 26, 2019

Merge pull request #899 from amazeeio/895-jobs-from-deploymentconfigs
Get job pod templates from DeploymentConfig instead of running Pods

@Schnitzel Schnitzel merged commit df0cc54 into master Feb 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.