Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node modules #994

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@rocketeerbkw
Copy link
Member

rocketeerbkw commented Mar 27, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Some of the node modules in our tree are deprecated and/or out of date. I was not able to individually update them (I think using yarn workspaces is what makes this difficult) so instead I ran yarn update which updated every single package.

In order to avoid deprecated packages in @slack/client I had to upgrade that to ^4.0. According to the migration guide, there are no breaking changes in the way we use the library.

Changelog Entry

Improvement - Upgraded all node modules

Closing issues

N/A

@rocketeerbkw rocketeerbkw marked this pull request as ready for review Mar 27, 2019

@Schnitzel Schnitzel merged commit de0e5dc into master Mar 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@rocketeerbkw rocketeerbkw deleted the upgrade-node-modules branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.