@sandsalamand
Latest commit 4f6731e Dec 18, 2022 History
* Got config toggles working.
The code is a mess, with loads of comments and half-implemented ideas.
* Tried replacing the source audio for Dark Bramble with Deku music, but it doesn't trigger reliably and doesn't play outside of the ship.
* Tried culling fog sources outside of Bramble so that we don't need to keep track of when the player is in Bramble, but the FogOverrideVolumes have unreliable Sector data and their transforms are not reflective of the fog's world position.
Since I need to switch back to using the PlayerEnterBrambleDimension event for the music, I might as well just give up on culling fog and disable all fog when entering Bramble.

* *Organized the mod into multiple files
*Sorta gave up on filtering fog to Bramble
*Switched to using PlayerEnterBrambleDimension to toggle on/off fog
*GlobalMusicController takes too long to start playing the Bramble source music, so a future version of the mod will play it manually based on the enter event
*Removed DLLs from the repository

* working, but anglerfish move strangely, and there's a nullref upon exit to menu

* *Fixed the null reference error by patching AnglerfishAudioController and replacing UpdateLoopingAudio with a version that checks nulls before proceeding
Known issues still present:
*Deku music does not respect music volume slider
*Anglerfish acceleration is tied to the player's acceleration

* minor cleanup

* fixed angler acceleration bug by patching and overriding AnglerfishController.OnSectorOccupantsUpdated

* cleaned up a little

* Fixed bugs and cleaned up. Only known issue remaining is that the Anglerfish's FogLight leaves a faint smudge on screen even after being deactivated.

* got fog lights toggleable, but afterimages are still present

* cleaned up music code a little, moved patch-adding to Patches class

* fixed FogLight afterimages bug by disabling the fog light canvas via FogLightManager when fish are disabled

* fixed fogLights in a betterr way

* cleaned up music swapping code, moved it to a new MusicManager class

* fixed duplicate list additions when reloading solar system

* removed some useless debugging

* updated manifest.json

* *Updated manifest.json to new schema
*Moved config values to BrambleConfig struct to make it easier to serialize for QSB
*Added ConfigChanged event to allow QSB-compatibility addon to react and send a sync message

* switched back to toggling the foglight canvas to disable angler FogLights because it looks better when there's no fog, and is more reliable

* fixed bugs in common scenarios, found a strange bug where fog afterimages glitch the second time you enter bramble. investigating

* fixed bugs in common scenarios, found a strange bug where fog afterimages glitch the second time you enter bramble. investigating

* fixed the previous bug. tested loads of edge cases, and couldn't find any more bugs. starting final cleanup now

* cleaned up some stuff, but found a rare bug relating to toggling fish multiple times in different locations. checking pre-cleanup commit to see if it was there too, or if I introduced it during cleanup

* final bug fixed

* removed some unncessary FogLight toggling code

* removed unnecessary code, realized that the game wasn't calling PlayerExitBrambleDimension event on death, so manually added it. tested every strange scenario I could think of to try to break the mod, and didn't succeed in finding any more bugs.
2 contributors

Users who have contributed to this file

@Raicuparta @sandsalamand