Add a ToIonDataSource implementation for std::io::Cursor and references to byte arrays. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good, but the build is currently failing. Could you take a look when you have a chance? |
|
Yeah, I forgot to add some files and test updates, sorry. I have a few branches going. I'll get back to this in a little bit. Thanks. |
jnicholls
force-pushed
the
to-ion-data-source
branch
from
ab3e4a0
to
39ef3b3
Compare
…es to byte arrays.
jnicholls
force-pushed
the
to-ion-data-source
branch
from
39ef3b3
to
9721de6
Compare
|
Seems like the builds are stuck pending... 🤷♂️ |
Codecov Report
@@ Coverage Diff @@
## main #406 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 82 82
Lines 14059 14059
=======================================
+ Hits 12438 12439 +1
+ Misses 1621 1620 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zslayton
approved these changes
Aug 12, 2022
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing?
ToIonDataSourceforstd::io::Cursorfor completeness.ToIonDataSourcefor&[u8; N]as an additional acceptable type for any method accepting aToIonDataSource, such as the readers.IonDataSourcetrait to have default implementations, since it requires BufRead.ToIonDataSourceto put a trait bound on theDataSourceassociated type ofIonDataSourceinstead ofBufReadwhich is more specific and correct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.