XML still being parsed when use_cache_flow is false #15

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@ecaron
ecaron commented Dec 16, 2011

The fix that was introduced in 1.4.8 only worked when $this->use_cache_flow was true. Now $this->parse_the_response is checked in both places where $this->parse_callback may be called.

amazonwebser... and others added some commits Dec 15, 2011
amazonwebservices 1.5 release. https://aws.amazon.com/releasenotes/PHP/3719565440874916 efa88cc
Eric Caron Completing the fix introduced in 1.4.8 to address "The XML and JSON o…
…bjects stored in Amazon S3 are no longer parsed when downloaded using the get_object() method."

The fix that was introduced in 1.4.8 only worked when $this->use_cache_flow was true. Now $this->parse_the_response is checked in both places where $this->parse_callback may be called.
9e3ec7a
@skyzyx
Contributor
skyzyx commented Dec 29, 2011

Reviewing the patch with relevant teams inside of Amazon.

The AWS SDK for PHP is licensed under the Apache 2.0 license. Would you be willing to license this patch under the same legal terms?

@ecaron
ecaron commented Dec 30, 2011

Absolutely. Is written confirmation enough or is there some other process I
need to follow? I would like to make sure all of my future patches are seen
as Apache 2 licensed to help speed things along too.

@skyzyx
Contributor
skyzyx commented Jan 3, 2012

Just ensure that you specify that you release your changes under the Apache 2.0 license in your pull request.

@skyzyx
Contributor
skyzyx commented Jan 6, 2012

I've pulled this patch into our internal source tree. The fix will go out with an upcoming release.

Thanks for the contribution! :)

@skyzyx skyzyx closed this Jan 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment