Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Removed a temporary `$s3->use_ssl = false;` mode. #21

Closed
wants to merge 36 commits into from

4 participants

@sjlu

Object URLs should be able to be grabbed as 'https' and should be an option that a user should set.

amazonwebser... added some commits
amazonwebservices AWS SDK for PHP 1.0 0ca2016
amazonwebservices 1.0 release. http://aws.amazon.com/releasenotes/PHP/4259 208ea4e
amazonwebservices 1.0.1 release. http://aws.amazon.com/releasenotes/PHP/4361 6fbc299
amazonwebservices 1.1 release. http://aws.amazon.com/releasenotes/PHP/8483333174056215 cbb5177
amazonwebservices 1.2 release. http://aws.amazon.com/releasenotes/PHP/2597056313659183 d8cca53
amazonwebservices 1.2.1 release. http://aws.amazon.com/releasenotes/PHP/9413701600681822 771dc94
amazonwebservices 1.2.2 release. http://aws.amazon.com/releasenotes/PHP/7779312442240750 85d234d
amazonwebservices 1.2.3 release. http://aws.amazon.com/releasenotes/PHP/2186402446547287 4e194a9
amazonwebservices 1.2.4 release. http://aws.amazon.com/releasenotes/PHP/0721416574824769 b56b8b1
amazonwebservices 1.2.5 release. http://aws.amazon.com/releasenotes/PHP/5735362665697704 f77cebb
amazonwebservices 1.2.6 release. http://aws.amazon.com/releasenotes/PHP/1553377899765189 e0f1790
amazonwebservices 1.3 release. http://aws.amazon.com/releasenotes/PHP/9632298582898209 406dd51
amazonwebservices 1.3.1 release. http://aws.amazon.com/releasenotes/PHP/0253227731786490 1a7232c
amazonwebservices 1.3.2 release. http://aws.amazon.com/releasenotes/PHP/9093240944791442 dcafcc3
amazonwebservices 1.3.3 release. http://aws.amazon.com/releasenotes/PHP/0259034806283697 b98a5de
amazonwebservices 1.3.4 release. http://aws.amazon.com/releasenotes/PHP/5688066312133669 cd73cd2
amazonwebservices 1.3.5 release. https://aws.amazon.com/releasenotes/PHP/1251631559033530 7e93c6c
amazonwebservices 1.3.6 release. https://aws.amazon.com/releasenotes/PHP/9111681429877701 a0dde0e
amazonwebservices 1.3.7 release. http://aws.amazon.com/releasenotes/PHP/7012486880417552 5cc4ea3
amazonwebservices 1.4 release. https://aws.amazon.com/releasenotes/PHP/4817931895245610 ec87e31
amazonwebservices 1.4.0.1 release. https://aws.amazon.com/releasenotes/PHP/869523791306… aeb780e
amazonwebservices 1.4.1 release. https://aws.amazon.com/releasenotes/PHP/9347733878812478 74775b6
amazonwebservices 1.4.2 release. https://aws.amazon.com/releasenotes/PHP/7771598794319191 3b009f7
amazonwebservices 1.4.2.1 release. https://aws.amazon.com/releasenotes/PHP/987322414199… c473eff
amazonwebservices 1.4.3 release. https://aws.amazon.com/releasenotes/PHP/5605694453189843 5ca685f
amazonwebservices 1.4.4 release. https://aws.amazon.com/releasenotes/PHP/2759956528299919 281c2bb
amazonwebservices 1.4.5 release. https://aws.amazon.com/releasenotes/PHP/2243855095011892 6b0c700
amazonwebservices 1.4.6 release. https://aws.amazon.com/releasenotes/PHP/9854036991373529 c67bc85
amazonwebservices 1.4.6.1 release. https://aws.amazon.com/releasenotes/PHP/985403699137… 8cf3e0f
amazonwebservices 1.4.7 release. https://aws.amazon.com/releasenotes/PHP/1407995226377381 cfa8a03
amazonwebservices 1.4.8 release. https://aws.amazon.com/releasenotes/PHP/2917833986024270 a60a0ad
amazonwebservices 1.4.8.1 release. https://aws.amazon.com/releasenotes/PHP/291783398602… 4c4a335
amazonwebservices 1.5 release. https://aws.amazon.com/releasenotes/PHP/3719565440874916 a51029f
amazonwebservices 1.5.0.1 release. https://aws.amazon.com/releasenotes/PHP/371956544087… b9012df
@ardell

Looks like all previous versions of the pear package have been removed from the aws pear channel along with this release. Would you mind leaving up at least one older version since this new version contains backwards-incompatible changes. This broke one of our builds today...

They're all working for me. All of the old versions are still in the bucket. I was just able to uninstall the SDK via PEAR, then re-install specific versions. Is there something more specific that's broken?

Yep you're right, sorry about that. Pear was saying "upgrade failed" and only showed the latest version on pear remote-list which made us think that older versions had been taken down. Thanks!

amazonwebser... and others added some commits
amazonwebservices 1.5.1 release. https://aws.amazon.com/releasenotes/PHP/0724070929559591 96fc205
@sjlu sjlu Removed a temporary `$s3->use_ssl = false;` mode. Object URLs should …
…be able to be grabbed as 'https' and should be an option that a user should set.
a91a249
@skyzyx

I'm unclear about what issue this is attempting to solve. Could you clarify?

@sjlu

Right now it sets it to false and because of it, https is not added to the URL when requesting it. The reason why I got rid of that line is because it should be user defined if they want the https URL instead of it always being false.

@jeremeamia
Owner

There are reasons why we do it the way we do (see https://forums.aws.amazon.com/thread.jspa?threadID=91051). However, you will be able to opt in to using https in our next release be adding 'http' => true to the $opt array for that function.

@jeremeamia jeremeamia closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 28, 2010
  1. AWS SDK for PHP 1.0

    amazonwebservices authored
Commits on Feb 28, 2011
  1. 1.0 release. http://aws.amazon.com/releasenotes/PHP/4259

    amazonwebservices authored
  2. 1.0.1 release. http://aws.amazon.com/releasenotes/PHP/4361

    amazonwebservices authored
Commits on Mar 2, 2011
Commits on Mar 15, 2011
Commits on Mar 25, 2011
Commits on Apr 6, 2011
Commits on May 11, 2011
Commits on Jun 8, 2011
Commits on Jun 21, 2011
Commits on Jul 13, 2011
Commits on Jul 26, 2011
Commits on Aug 4, 2011
Commits on Aug 23, 2011
Commits on Sep 2, 2011
Commits on Sep 8, 2011
Commits on Oct 1, 2011
Commits on Oct 12, 2011
Commits on Oct 22, 2011
Commits on Nov 3, 2011
Commits on Nov 4, 2011
Commits on Nov 9, 2011
Commits on Dec 8, 2011
Commits on Dec 9, 2011
Commits on Dec 20, 2011
Commits on Dec 21, 2011
Commits on Jan 18, 2012
Commits on Jan 28, 2012
  1. @sjlu

    Removed a temporary `$s3->use_ssl = false;` mode. Object URLs should …

    sjlu authored
    …be able to be grabbed as 'https' and should be an option that a user should set.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  services/s3.class.php
1  services/s3.class.php
@@ -2650,7 +2650,6 @@ public function get_object_url($bucket, $filename, $preauth = 0, $opt = null)
// Authenticate to S3
$current_ssl_setting = $this->use_ssl;
- $this->use_ssl = false;
$response = $this->authenticate($bucket, $opt);
$this->use_ssl = $current_ssl_setting;
Something went wrong with that request. Please try again.