Revert back to numeric versions #30

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@boombatower

I am not sure of the reason behind the change from numeric to string version in the CFRUNTIME_VERSION constant (8465067#L3R118). Currently we detect the constant and use version_compare (http://php.net/version_compare) to compare against the minimum version supported by the integration code. It looks like the number still exists in the XML with could be parse and used instead, but that is definitely more work.

I would like to hear some thoughts on this or perhaps it was an accident?

@jeremeamia

This comment has been minimized.

Show comment
Hide comment
@jeremeamia

jeremeamia May 21, 2012

Contributor

That was definitely an accident. 😞

Contributor

jeremeamia commented May 21, 2012

That was definitely an accident. 😞

@jeremeamia

This comment has been minimized.

Show comment
Hide comment
@jeremeamia

jeremeamia May 21, 2012

Contributor

I'll get it fixed soon. I can't accept the pull request straight up for logistical reasons, but I'll close it when it's fixed. Sorry for the inconvenience, but thanks for letting us know.

Contributor

jeremeamia commented May 21, 2012

I'll get it fixed soon. I can't accept the pull request straight up for logistical reasons, but I'll close it when it's fixed. Sorry for the inconvenience, but thanks for letting us know.

@boombatower

This comment has been minimized.

Show comment
Hide comment
@boombatower

boombatower May 21, 2012

Sounds good, thanks.

Sounds good, thanks.

@jeremeamia

This comment has been minimized.

Show comment
Hide comment
@jeremeamia

jeremeamia May 25, 2012

Contributor

Fixed in 1.5.6.1.

Contributor

jeremeamia commented May 25, 2012

Fixed in 1.5.6.1.

@jeremeamia jeremeamia closed this May 25, 2012

@boombatower

This comment has been minimized.

Show comment
Hide comment
@boombatower

boombatower May 26, 2012

Confirmed it works (not that there was much doubt). Thanks for getting that fixed.

Confirmed it works (not that there was much doubt). Thanks for getting that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment