Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

prevent notice for unfound keys on s3 #34

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

Very simple preventing of notices.. By checking the object->isOk() before directly accessing the header[content-length] of the result...

@fruitl00p fruitl00p Prevent notices for not unfound files
By checking the object->isOk() before directly heading into the unfound header array
b1e8ebf
Contributor

jeremeamia commented Aug 7, 2012

Good catch. I'll see what we can do to integrate this soon.

Will you be using the same checks for other calls aswell? Just to be consistent?

fruitl00p added some commits Aug 29, 2012

@fruitl00p fruitl00p updated update_object to check for succesful metadata fetch... return…
… 'void' if no successful metadata was retrieved for $filename

(this prevents notices updating meta_data on deleted objects)
37821a7
@fruitl00p fruitl00p Merge remote-tracking branch 'origin/master' ef4b911
Contributor

jeremeamia commented Sep 22, 2012

I added these fixes for the next release. We don't accept pull request directly right now due to logistical reasons, but I'll add you to our CONTRIBUTORS doc.

@jeremeamia jeremeamia closed this Sep 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment