Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only output exception message to log, not entire html response #1025

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@westonganger
Copy link
Contributor

commented Jan 7, 2019

Was getting super annoyed by the cluttered log when the error page showed. Heres a PR to improve that by only outputing the exception message to log, not the entire html response. Fixes #1003

@westonganger westonganger changed the title Only ouput exception message to log, not entire html response Only output exception message to log, not entire html response Jan 7, 2019

@robacarp
Copy link
Member

left a comment

this is great, thanks @westonganger

@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

I think this failure is cleaned up by #1027

@robacarp robacarp merged commit 14a57b9 into amberframework:master Jan 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Awesome! Thanks as always @westonganger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.