Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat mailer as first class citizen in new app #1037

Merged
merged 1 commit into from Jan 25, 2019

Conversation

4 participants
@westonganger
Copy link
Contributor

commented Jan 14, 2019

Currently the mailer initializers and files are only added if you use the generator which is super confusing for people who do it by hand.

The mailer should be treated as a first class citizen. Lets make the mailer opt-out instead of opt-in. If an application does not need the mailer they can comment out the initializer or delete it.

Fixes #1031

I will create a PR to update the docs accordingly afterwards.

@westonganger westonganger force-pushed the westonganger:custom/patch-3 branch 3 times, most recently from d6ac988 to 08a2791 Jan 14, 2019

@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

cc @elorest @drujensen @eliasjpr

I like this. The default state of a webapp these days is to send email, so I think it makes sense.

@eliasjpr
Copy link
Contributor

left a comment

I like but specs are failing 😞 I will approve as soon specs are green

@westonganger westonganger force-pushed the westonganger:custom/patch-3 branch from 11c8a46 to 193efbf Jan 24, 2019

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Updated. Specs are now passing.

Framework 2019 automation moved this from To do to In progress Jan 24, 2019

@robacarp robacarp merged commit 6de3689 into amberframework:master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Framework 2019 automation moved this from In progress to Done Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.