Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all code blocks from ruby to crystal #140

Open
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@westonganger
Copy link
Contributor

commented Feb 3, 2019

No description provided.

@faustinoaq faustinoaq requested a review from eliasjpr Feb 7, 2019

@faustinoaq faustinoaq added this to To do in Framework 2019 via automation Feb 7, 2019

@robacarp

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

At one point these had to be ruby because gitbook didn't support crystal syntax highlighting. Crystal and Ruby differ enough that ruby syntax highlighting applied to crystal is starting to look less and less readable.

Does gitbook support crystal now?

@elorest

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Definitely prefer this if gitbook supports crystal. If it doesn't maybe we should consider not using gitbook?

Framework 2019 automation moved this from To do to In progress Feb 11, 2019

@eliasjpr
Copy link
Contributor

left a comment

Lgtm as long crystal is supported by Gitbook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.