Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update params.md #168

Merged
merged 2 commits into from Nov 21, 2019

Conversation

@adacosta
Copy link
Contributor

adacosta commented Nov 21, 2019

Fix typos, and add a couple commas. Please consider using a consistent term for the params object as "params object" or "params hash" but maybe not both ?

Fix typos, and add a couple commas. Please consider using a consistent term for the params object as "params object" or "params hash" but maybe not both ?

```ruby
params[:key] # => "My String"
params["key"] # => "My String"
```

To access the validated params hash. It will only contain entries that have been sucesssfully validated using the Validation API. If you do not use the Validation API this will return an empty Hash.
To access the validated params hash. It will only contain entries that have been successfully validated using the Validation API. If you do not use the Validation API this will return an empty Hash.

This comment has been minimized.

Copy link
@drujensen

drujensen Nov 21, 2019

Member

To access the validated params hash. is not a complete sentence. Maybe replace it with The params object will only contain entries that have been successfully validated using the Validation API.

This comment has been minimized.

Copy link
@adacosta

adacosta Nov 21, 2019

Author Contributor

updated

Improve params object validation wording, per review comment.
@robacarp robacarp merged commit c877e6b into amberframework:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.