Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `cc` & `bcc` with Quartz::Composer #22

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@westonganger
Copy link
Contributor

commented Jan 10, 2019

Also solves #23

@robacarp
Copy link
Member

left a comment

Thanks @westonganger. This looks right, but there's no composer test to update to validate. I've created #23 for that, unless you want to contribute one wink

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Sure. I have now added a spec for Quartz::Composer

@westonganger westonganger force-pushed the westonganger:patch-3 branch from 927c1c4 to 457bdd9 Jan 10, 2019

@westonganger westonganger force-pushed the westonganger:patch-3 branch from 457bdd9 to 2785c47 Jan 10, 2019

@drujensen

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

thanks for the test coverage!

@drujensen drujensen merged commit 3a2616d into amberframework:master Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@westonganger awesome! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.