Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_*_recipient methods #24

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@westonganger
Copy link
Contributor

commented Jan 10, 2019

To remove a recipient:

remove_to_recipient email: "to@foobar.com"
remove_cc_recipient email: "cc@foobar.com"
remove_bcc_recipient email: "bcc@foobar.com"

I wanted this feature because sometime I add recipients but then later want to scrub the list of any "Soft-deleted" users before sending the email.

@westonganger westonganger force-pushed the westonganger:add_remove_recipient branch from 28560f4 to 8129a0b Jan 10, 2019

@drujensen
Copy link
Member

left a comment

I am ok with this change. lgtm. @robacarp?

@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

I'm not sure this should fall under the responsibility of the mailer...why not just reject from your user array before ever adding users to the mailer?

@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

I thought of that but this is still nice to have. You might not be able make that work if your passing around the mailer object making changes in a chain style format.

@robacarp

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

okay, sure. I don't see any harm in it. Thanks @westonganger

@robacarp robacarp merged commit d8a05bd into amberframework:master Jan 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.