Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some WordPress chains from plugins #50

Merged
merged 4 commits into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@erwanlr
Copy link
Contributor

commented Apr 27, 2019

Notes:
I had to play with the folder naming a bit, as WordPress/WooCommerce/RCE1 didn't work.

I've also updated the Readme to reflect the latest GadgetChains added, including these ones.

I wonder if I should put them in a plugins/plugin sub folder, as there might be Gadgets in themes at some point (if not already xD)

@cfreal cfreal merged commit d776885 into ambionics:master Apr 29, 2019

@cfreal

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

Amazing, thanks. I changed the core code so that modules can now have their own subdirectory:
gadgetchains/Wordpress/WooCommerce/RCE/1 for instance.

@erwanlr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

Great, thanks!

Is it worth to also put them into a plugin/plugins subdirectory ? My main concern with that is the length of the name displayed which could be quite long.

Potential candidate would be:

  • gadgetchains/Wordpress/plugins/XXXX/RCE/1
  • gadgetchains/Wordpress/plugin/XXXX/RCE/1
  • gadgetchains/Wordpress/p/XXX/RCE/1

Then, when there will be some chains affecting themes at some point, they would be put in themes/theme/t

@erwanlr erwanlr deleted the erwanlr:yet-another-stars-rating-rce branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.