New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group of small fixes: fix test input; code clean-up #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@viviparous

viviparous commented Jun 30, 2016

Fix to test data based on observation of test output.

Code clean-up based on perlcritic output.

This work is for N Bowers' Pull-Request Challenge.

@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Jun 30, 2016

Owner

Hi
Can you please rebsase it with utf8 branch, and prepare a PR there?
We are in the process of having UTF-8 everywhere (or mostly), and it would make things easier.

In any case, thanks! :-D

Owner

ambs commented Jun 30, 2016

Hi
Can you please rebsase it with utf8 branch, and prepare a PR there?
We are in the process of having UTF-8 everywhere (or mostly), and it would make things easier.

In any case, thanks! :-D

@@ -1,2 +1,3 @@
@comment{{7890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567abc-this-is-way-oveaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar }
}

This comment has been minimized.

@ambs

ambs Jul 1, 2016

Owner

it is supposed to have the warning :-)

@ambs

ambs Jul 1, 2016

Owner

it is supposed to have the warning :-)

@@ -26,7 +26,9 @@ require DynaLoader;
our $VERSION='0.74';
@ISA = qw(Exporter DynaLoader);
#@ISA = qw(Exporter DynaLoader);
use base qw(Exporter DynaLoader);

This comment has been minimized.

@ambs

ambs Jul 1, 2016

Owner

Accordingly with base documentation:
Unless you are using the "fields" pragma, consider this module discouraged in favor of the lighter-weight "parent".

So, can you please change to parent? Also, add it to the dependencies.

@ambs

ambs Jul 1, 2016

Owner

Accordingly with base documentation:
Unless you are using the "fields" pragma, consider this module discouraged in favor of the lighter-weight "parent".

So, can you please change to parent? Also, add it to the dependencies.

This comment has been minimized.

@ambs

ambs Jul 1, 2016

Owner

In fact, it seems that parent is not available in Perl 5.8 by default, so I would like to stick to @isa.
Sorry

@ambs

ambs Jul 1, 2016

Owner

In fact, it seems that parent is not available in Perl 5.8 by default, so I would like to stick to @isa.
Sorry

This comment has been minimized.

@dolmen

dolmen Jul 5, 2016

parent is available on CPAN for perl < 5.10.1

@dolmen

dolmen Jul 5, 2016

parent is available on CPAN for perl < 5.10.1

This comment has been minimized.

@ambs

ambs Jul 5, 2016

Owner

I know. But if we are not getting anything extra from it, why change?

@ambs

ambs Jul 5, 2016

Owner

I know. But if we are not getting anything extra from it, why change?

@ambs ambs closed this Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment