New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix buffer overrun issue due to strncat usage #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@daleevans
Contributor

daleevans commented May 25, 2015

strncat(a,b,n) will actually write n+1 bytes because of the terminating NULL, unlike strlcpy (non-standard OpenBSD function) which writes exactly n. this may end up dropping a character, but this is debug output from a failure case, so it doesn't matter much.

this fixes CPAN bug https://rt.cpan.org/Public/Bug/Display.html?id=80458

@daleevans daleevans closed this May 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment