Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Works with latest WebOb (1.2b3) #21

Closed
wants to merge 1 commit into from

3 participants

@mLewisLogic

using req.params rather than req.str_params

@amcfague
Owner

Since WebOb 1.2 is not released yet (and has been in beta for who knows how long), I am going to hold off on merging this pull request until 1.2 is released.

Thought that req.params is valid for WebOb 1.1.x?

@goodwillcoding

WebOb 1.2 went stable on 5/23 so I think its good to go there. I would like to +1 this patch.

Also, str_params was deprecate in 1.2 but params is valid in 1.1 and 1.2. So the patch should work regardless of the version.

@amcfague
Owner

This has gotten merged.

@amcfague amcfague closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 15, 2012
  1. @mLewisLogic

    fix for latest WebOb

    mLewisLogic authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 3 deletions.
  1. +1 −1  linesman/middleware.py
  2. +1 −2  setup.py
View
2  linesman/middleware.py
@@ -302,7 +302,7 @@ def show_profile(self, req):
else:
# Otherwise, prepare the graph for display!
cutoff_percentage = float(
- req.str_params.get('cutoff_percent', 5) or 5) / 100
+ req.params.get('cutoff_percent', 5) or 5) / 100
cutoff_time = int(
session.duration * cutoff_percentage * CUTOFF_TIME_UNITS)
graph, root_nodes, removed_edges = prepare_graph(
View
3  setup.py
@@ -7,8 +7,7 @@
import sys
-install_requires = ["mako", "networkx", "PIL", "pygraphviz", 'Paste',
- 'WebOb==1.1.1']
+install_requires = ["mako", "networkx", "PIL", "pygraphviz", 'Paste', 'WebOb']
# ordereddict is required for versions < 2.7; its included in collections in
# versions 2.7+ and 3.0+
Something went wrong with that request. Please try again.