From dc3df2f692f75b0b4d096da68bc81da5bd73aaeb Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Fri, 16 Feb 2024 14:54:08 -0500 Subject: [PATCH] Add in a comment explaining where Python3::Interpreter comes from. (#510) This is a compromise between doing the very correct thing (find_package(Python3) in ament_python_install_packge), and not changing things unnecessarily. Signed-off-by: Chris Lalancette --- ament_cmake_python/cmake/ament_python_install_package.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ament_cmake_python/cmake/ament_python_install_package.cmake b/ament_cmake_python/cmake/ament_python_install_package.cmake index d035ff9a..25a08092 100644 --- a/ament_cmake_python/cmake/ament_python_install_package.cmake +++ b/ament_cmake_python/cmake/ament_python_install_package.cmake @@ -136,6 +136,9 @@ setup( endif() endif() + # Technically, we should call find_package(Python3) first to ensure that Python3::Interpreter + # is available. But we skip this here because this macro requires ament_cmake, and ament_cmake + # calls find_package(Python3) for us. get_executable_path(python_interpreter Python3::Interpreter BUILD) add_custom_target(