Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ament_export_interfaces to ament_export_targets #237

Closed
dirk-thomas opened this issue Apr 7, 2020 · 3 comments
Closed

rename ament_export_interfaces to ament_export_targets #237

dirk-thomas opened this issue Apr 7, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dirk-thomas
Copy link
Contributor

dirk-thomas commented Apr 7, 2020

"interfaces" has another meaning in the ROS IDL context which can be misleading. Therefore I proposed to rename the existing API to use the term "targets" instead.

For the actual change the existing API can be kept but deprecated.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Apr 7, 2020
@jacobperron
Copy link
Contributor

jacobperron commented Apr 8, 2020

I don't think that the meanings between the ament command and the rosidl command are confusing since the packages are responsible for two completely different things (they are already segmented in my mind). If anything, the command rosidl_generate_interfaces may be more confusing as it is a CMake function not referring to CMake interfaces.

That being said, I'm not opposed to renaming ament_export_interfaces as proposed.

@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Apr 8, 2020

@dirk-thomas dirk-thomas self-assigned this Apr 8, 2020
@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Apr 9, 2020

FastRTPS-only builds since neither of the RMW impl. packages uses that symbol anyway:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants