deprecate ament_export_interfaces() in favor of ament_export_targets() #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
…s, add deprecation message for ament_export_interfaces(), add ament_cmake_export_targets to ament_cmake Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
To be merged without squashing to preserve the two commits - copying files in one, modifying them in another. |
jacobperron
approved these changes
Apr 9, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/rename_ament_export_interfaces
branch
|
Related to ros2/ros2#904. |
j-rivero
pushed a commit
that referenced
this pull request
Apr 27, 2020
#238) * duplicate ament_cmake_export_interfaces to ament_cmake_export_targets Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * update names in ament_cmake_export_targets after duplicating the files, add deprecation message for ament_export_interfaces(), add ament_cmake_export_targets to ament_cmake Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #237.