set cmp0026 to OLD until we can migrate to use $<TARGET_FILE:...> #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,10 @@ function(ament_cmake_symlink_install_targets) | |||
| endif() | |||
| # TODO consider using a generator expression instead | |||
| # $<TARGET_FILE:target> | |||
| # Until them use the old policy. | |||
There was a problem hiding this comment.
The comment suggests that this "changes" the policy which is not the case. Since the code set 2.8.3 as the minimum required version the old policy is already being used implicitly.
Can you please update the comment to state the reason for setting the policy explicitly more clearly. E.g.:
# set the policy explicitly in order to avoid warning with newer CMake versions
|
The changed location is only one case there Therefore I assume it does not fix #27 yet when building tests is enabled. I think the same thing needs also to be done in other locations: |
|
Ok, I've updated the pr. |
|
+1 |
wjwwood
added a commit
that referenced
this pull request
Sep 15, 2015
set cmp0026 to OLD until we can migrate to use $<TARGET_FILE:...>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #27.
Connects to #27