remove gmock/gtest/nose packages from ament_cmake #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might break things that are already implicitly depending on this, we'll need to test it well. |
This was referenced Sep 17, 2015
|
There was only one case where I had to add the missing dependency: ros2/rosidl#40 |
|
lgtm, but my ws it sort of a mess locally. Will CI be sufficient? |
|
I built a complete clean workspace locally and the CI jobs are running for all three platforms (which are also starting from scratch). I would say that should be sufficient - can't imagine why that would pass but fail somewhere else. |
|
I was thinking of silent failures, but I guess they would fail hard without the dependencies. +1 |
dirk-thomas
added a commit
that referenced
this pull request
Sep 19, 2015
remove gmock/gtest/nose packages from ament_cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback in ament/ament_lint#28 (comment)
http://ci.ros2.org/job/ros2_batch_ci_linux/371/
http://ci.ros2.org/job/ros2_batch_ci_osx/277/
http://ci.ros2.org/job/ros2_batch_ci_windows/420/