require CMake 3.5 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
in progress
This was referenced Jun 15, 2016
dirk-thomas
force-pushed
the
cmake35
branch
4 times, most recently
from
38a68d7
to
0b8a5a9
Compare
… variable expansion
| _set_cmake_policy_to_new_if_available(CMP0022) | ||
| _set_cmake_policy_to_new_if_available(CMP0023) | ||
| _set_cmake_policy_to_new_if_available(CMP0042) | ||
|
|
There was a problem hiding this comment.
Why are these no longer required? Because of the new cmake_minimum_required value?
There was a problem hiding this comment.
Yes, all policies already available in the CMake version specified as minimum are enabled by default.
dirk-thomas
added
in review
40 tasks
kenji-miyake
pushed a commit
to kenji-miyake/ament_cmake
that referenced
this pull request
Oct 20, 2021
require CMake 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.