Add flake8 linter ignore support #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support of AMENT_LINT_AUTO_FILE_EXCLUDE is required for all packages in ament_lint_auto * Add a more practical usage example with globbing Signed-off-by: Ryan Friedman <ryan_friedman@trimble.com>
mjeronimo
approved these changes
Nov 16, 2022
|
My bad. Missed this when I commented out some code right before push. Will fix. |
Signed-off-by: Ryan Friedman <ryan_friedman@trimble.com>
RFRIEDM-Trimble
force-pushed
the
add_flake8_linter_ignore_support
branch
from
450789b
to
d9c2bee
Compare
|
Fixed the white space, tests should pass. |
aprotyas
suggested changes
Nov 17, 2022
|
Can someone run CI? |
aprotyas
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
@RFRIEDM-Trimble approving preemptively, mind fixing the EOL whitespace issue and amending the commit message to satisfy DCO?
RFRIEDM-Trimble
force-pushed
the
add_flake8_linter_ignore_support
branch
from
72263d2
to
710724d
Compare
Done, the whitespace was already fixed btw. I didn't realize accepting change suggestions in the UI that it doesn't sign it for me. Sorry for troubles. |
Co-authored-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu> Signed-off-by: Ryan Friedman <ryan_friedman@trimble.com>
RFRIEDM-Trimble
force-pushed
the
add_flake8_linter_ignore_support
branch
from
710724d
to
f850382
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #423