Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPGConstituents: Use of E39 Actor #38

Closed
steads opened this Issue Jul 4, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@steads
Copy link

steads commented Jul 4, 2016

The mapping to E39 Actor is correct as there are both individuals (E21 Person) and groups (E74 Group). However this makes the mapping rather weak as the use of the superclass restricts the utility of the resulting data.

@VladimirAlexiev

This comment has been minimized.

Copy link
Member

VladimirAlexiev commented Jul 14, 2016

Right!
I checked all values of column Institution, and indeed they represent Groups. With the possible exceptions of the following (most of them are not Persons either)

Ackerman
Admiralty Arch
Anonymous Loan to the Boston Athenaeum
Antoinette
Benjamin Harrison Presidential Site
BELL, RON
Belgrave Square
Violinist
Widow
William
You Can Please Some Of The...
Young

@VladimirAlexiev

This comment has been minimized.

Copy link
Member

VladimirAlexiev commented Jul 14, 2016

As mentioned in #41, #42 this should be done. It's not hard to do: switch on presence of Institution field.

Steve, maybe change the title to "... use E21 Person vs E74 Group"

@edgartdata

This comment has been minimized.

Copy link

edgartdata commented Aug 2, 2016

It seems that there is nothing for NPG to do here since they provided a separate Institution column with the names of the institutions and the value NULL for instances when the field does not apply to persons.

@bsnikhila bsnikhila closed this Apr 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.