-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no colors option #211
Merged
anescobar1991
merged 8 commits into
americanexpress:master
from
avlyalin:fix-noColors-option
May 27, 2020
Merged
Fix no colors option #211
anescobar1991
merged 8 commits into
americanexpress:master
from
avlyalin:fix-noColors-option
May 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
previously approved these changes
May 21, 2020
anescobar1991
requested changes
May 26, 2020
Co-authored-by: Aleksey Lyalin <lyalin.alexey@gmail.com>
anescobar1991
approved these changes
May 27, 2020
Francois-Esquire
approved these changes
May 27, 2020
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes
noColors
option to allow chalk auto-detect colors support.Also, I had to add
env FORCE_COLOR=1
to the pre-commit hook:"pre-commit": "env FORCE_COLOR=1 npm test"
. For some reasons chalk doesn't detect colors on windows 10 when executed by husky (typicode/husky#350) and tests don't pass.Closes #114