Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKeeping change log up to date #36
Comments
ebkalderon
added
type: improvement
diff: easy
pri: low
labels
Mar 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
White-Oak
Mar 28, 2016
Contributor
Just an oppinion, but I believe this should be done by a mantainer, not by pull requesters. Interesting to see, what others think.
|
Just an oppinion, but I believe this should be done by a mantainer, not by pull requesters. Interesting to see, what others think. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 28, 2016
Member
@White-Oak I can see what you mean, just wanted to share an idea I've had floating around. I am curious, is there any kind of standard as to how maintainers should handle change log updates? Is it updated ad-hoc or done all at once?
|
@White-Oak I can see what you mean, just wanted to share an idea I've had floating around. I am curious, is there any kind of standard as to how maintainers should handle change log updates? Is it updated ad-hoc or done all at once? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
White-Oak
Mar 28, 2016
Contributor
@ebkalderon I know rustc team puts a tag like 'changelog-notes' and uses that for a next release.
|
@ebkalderon I know rustc team puts a tag like 'changelog-notes' and uses that for a next release. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 31, 2016
Member
I think this should remain the responsibility of the maintainer, since a stable change log should be part of a stable release schedule. We need to codify this on the wiki or in the CONTRIBUTING.md file, along with the branching model detailed in #27. Closing for now.
|
I think this should remain the responsibility of the maintainer, since a stable change log should be part of a stable release schedule. We need to codify this on the wiki or in the CONTRIBUTING.md file, along with the branching model detailed in #27. Closing for now. |
ebkalderon commentedMar 28, 2016
I believe that in CONTRIBUTING.md, we should add under Pull Requests some conditions that make sure people's pull requests also update CHANGELOG.md to some degree so it doesn't have to be done manually.
What those conditions should be is up for discussion. Personally, I believe that we should look towards Semantic Versioning for ideas: if you fix a known bug, introduce new functionality, overhaul an existing feature, or produce a breaking change, you should document it appropriately in the change log.
See issue #17 from a while back for more information about the CHANGELOG.md format we use.