New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping change log up to date #36

Closed
ebkalderon opened this Issue Mar 28, 2016 · 4 comments

Comments

Projects
2 participants
@ebkalderon
Member

ebkalderon commented Mar 28, 2016

I believe that in CONTRIBUTING.md, we should add under Pull Requests some conditions that make sure people's pull requests also update CHANGELOG.md to some degree so it doesn't have to be done manually.

What those conditions should be is up for discussion. Personally, I believe that we should look towards Semantic Versioning for ideas: if you fix a known bug, introduce new functionality, overhaul an existing feature, or produce a breaking change, you should document it appropriately in the change log.

See issue #17 from a while back for more information about the CHANGELOG.md format we use.

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 28, 2016

Contributor

Just an oppinion, but I believe this should be done by a mantainer, not by pull requesters. Interesting to see, what others think.

Contributor

White-Oak commented Mar 28, 2016

Just an oppinion, but I believe this should be done by a mantainer, not by pull requesters. Interesting to see, what others think.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 28, 2016

Member

@White-Oak I can see what you mean, just wanted to share an idea I've had floating around. I am curious, is there any kind of standard as to how maintainers should handle change log updates? Is it updated ad-hoc or done all at once?

Member

ebkalderon commented Mar 28, 2016

@White-Oak I can see what you mean, just wanted to share an idea I've had floating around. I am curious, is there any kind of standard as to how maintainers should handle change log updates? Is it updated ad-hoc or done all at once?

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 28, 2016

Contributor

@ebkalderon I know rustc team puts a tag like 'changelog-notes' and uses that for a next release.

Contributor

White-Oak commented Mar 28, 2016

@ebkalderon I know rustc team puts a tag like 'changelog-notes' and uses that for a next release.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 31, 2016

Member

I think this should remain the responsibility of the maintainer, since a stable change log should be part of a stable release schedule. We need to codify this on the wiki or in the CONTRIBUTING.md file, along with the branching model detailed in #27. Closing for now.

Member

ebkalderon commented Mar 31, 2016

I think this should remain the responsibility of the maintainer, since a stable change log should be part of a stable release schedule. We need to codify this on the wiki or in the CONTRIBUTING.md file, along with the branching model detailed in #27. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment