Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPasses have too much boilerplate #429
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Can we look at how gfx-hal handles passes? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
omni-viral
Oct 18, 2017
Member
@Rhuagh It's not really related. Our problem in Pass::apply implementation. Effect talks with gfx to configure pipeline.
omni-viral
commented
Oct 18, 2017
•
edited
Edited 1 time
-
omni-viral
edited Oct 18, 2017 (most recent)
edited
Edited 1 time
-
Oct 18, 2017 (most recent)
|
@Rhuagh It's not really related. Our problem in |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Rhuagh
Oct 18, 2017
Member
Ok, I have no idea, just brainstorming :) I like the idea of writing passes declarative.
Rhuagh
commented
Oct 18, 2017
•
edited
Edited 1 time
-
Rhuagh
edited Oct 18, 2017 (most recent)
edited
Edited 1 time
-
Oct 18, 2017 (most recent)
|
Ok, I have no idea, just brainstorming :) I like the idea of writing passes declarative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
omni-viral commentedOct 18, 2017
Right now
Passimplementation defines shaders and serve as simple pipeWorld->Encoder.The second part (pipe) requires enormous amount of boilerplate to write. Different passes share most of the code. If we add some more sophisticated features like caching buffers problem will grow.
Boilerplate should be reduced to minimum.
I think passes should be written in more declarative manner.