Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAudio does not take the time multiplier into account. #669
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Apr 25, 2018
Member
This feature would likely result in hilarious "chipmunk" sfx.
So of course I'm all for it :P
|
This feature would likely result in hilarious "chipmunk" sfx. So of course I'm all for it :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jojolepro
Apr 25, 2018
Collaborator
You could create a pink unicorn sound and make the pitch awfully low when they attack you :P
|
You could create a pink unicorn sound and make the pitch awfully low when they attack you :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Time scale != pitch, but would be hilarious anyways :P |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jojolepro
Apr 30, 2018
Collaborator
Actually yes because you are effectively changing the frequency of the sound by accelerating it.
|
Actually yes because you are effectively changing the frequency of the sound by accelerating it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Apr 30, 2018
Member
@Rhuagh Time scale can be adjusted independent of pitch, but it requires a more advanced analysis of the sound samples to preserve the wavelengths produced. You can't just haphazardly omit samples every X samples, you have to actually analyze the waves produced.
|
@Rhuagh Time scale can be adjusted independent of pitch, but it requires a more advanced analysis of the sound samples to preserve the wavelengths produced. You can't just haphazardly omit samples every X samples, you have to actually analyze the waves produced. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
OvermindDL1
May 1, 2018
Technically the pitch should be adjusted with the time, that is how it works in the real world after all. ^.^
OvermindDL1
commented
May 1, 2018
|
Technically the pitch should be adjusted with the time, that is how it works in the real world after all. ^.^ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
magnonellie
Jul 5, 2018
Contributor
So I was thinking of taking this one but I noticed that Output doesn't actually have access to the time scale. Should the different functions take a time_scale: Option<f32> parameter or something like that?
|
So I was thinking of taking this one but I noticed that |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jojolepro
Jul 5, 2018
Collaborator
https://github.com/amethyst/amethyst/blob/develop/amethyst_audio/src/systems/audio.rs. you can add time to this system and then do the things you need to do so that the audio frames are played faster or slower. Either make it actually play faster, or compress the frames.
|
https://github.com/amethyst/amethyst/blob/develop/amethyst_audio/src/systems/audio.rs. you can add time to this system and then do the things you need to do so that the audio frames are played faster or slower. Either make it actually play faster, or compress the frames. |
Xaeroxe
removed
the
good first issue
label
Jul 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Jul 5, 2018
Member
This is actually a rather complex issue involving multi-threaded communication channels so I'm removing the good first issue recommendation.
|
This is actually a rather complex issue involving multi-threaded communication channels so I'm removing the good first issue recommendation. |
jojolepro commentedApr 25, 2018
The audio system should change the audio playing speed of rodio depending on the time scale in the Time resource.
It should be configurable (disable/enable time scaling on a per sink basis)