Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upThe book should use the inclusion syntax for its examples #714
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ah, cool. Sounds excellent, then we get testing on it aswell. |
torkleyy
added
the
diff: easy
label
May 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
May 17, 2018
Member
I'm not sure including arbitrary line numbers is a good idea. It's really easy to have these offset by simple PR changes such as formatting or otherwise. It could become so difficult to maintain correctly that duplication might be preferable.
|
I'm not sure including arbitrary line numbers is a good idea. It's really easy to have these offset by simple PR changes such as formatting or otherwise. It could become so difficult to maintain correctly that duplication might be preferable. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@Xaeroxe Yeah, I realized that, too. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
May 17, 2018
Member
So, after having realized that do you still feel this is a good solution?
|
So, after having realized that do you still feel this is a good solution? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
May 17, 2018
Member
At least for the complete examples where we don't need lines, this does makes sense.
|
At least for the complete examples where we don't need lines, this does makes sense. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
May 17, 2018
Member
Like I think every pong chapter has them at the end, so we can do it for those.
|
Like I think every pong chapter has them at the end, so we can do it for those. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Moxinilian
Jun 26, 2018
Contributor
I'm not sure this is a good idea either. The representation in the repo always contains additional details to make it work in the context of the repo, most notably the assets path. Those details don't belong in the book.
|
I'm not sure this is a good idea either. The representation in the repo always contains additional details to make it work in the context of the repo, most notably the assets path. Those details don't belong in the book. |
torkleyy commentedMay 14, 2018
We can use
to include the code from our examples in the book, so we don't need to duplicate everything.