Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit out backend code into separate modules #89
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bjadamson
commented
Sep 7, 2016
|
I'm working on this at the moment. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bjadamson
Sep 8, 2016
#98 I just sent a pull request moving all of this code entirely, and instead depend on Gfx to handle the backend code.
bjadamson
commented
Sep 8, 2016
|
#98 I just sent a pull request moving all of this code entirely, and instead depend on Gfx to handle the backend code. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bjadamson
commented
Oct 6, 2016
|
idea for using traits for better separation: |
ebkalderon
added this to New
in Renderer
Feb 3, 2017
ebkalderon
removed
the
status: in-progress
label
Feb 3, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Complete, closing. |
Xaeroxe
closed this
Sep 15, 2017
omni-viral
moved this from New
to Done
in Renderer
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bjadamson commentedSep 6, 2016
Implementing a function for different back-ends all inline within the function body becomes unmaintainable over time.
Example:
https://github.com/amethyst/amethyst/blob/develop/src/context/src/asset_manager.rs#L118-L139
The different backend implementations should be moved to their own separate module.