Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed single frame animation #1015

Merged
merged 5 commits into from Oct 14, 2018

Conversation

Projects
None yet
5 participants
@mh84
Copy link
Contributor

commented Oct 11, 2018

Fixes #781

@Xaeroxe
Copy link
Member

left a comment

Thanks 😅

@mh84

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

Everyone knows these bugs where u have to do hours of debugging to find them and change a single line of code to fix them ;)

Show resolved Hide resolved examples/gltf/main.rs
@Rhuagh

Rhuagh approved these changes Oct 11, 2018

Copy link
Member

left a comment

Wow, in retrospect that was a pretty stupid check :P

@Rhuagh
Copy link
Member

left a comment

Could you add an entry to the changelog please?

@@ -67,6 +67,7 @@ The format is based on [Keep a Changelog][kc], and this project adheres to
* `LMenu` and `RMenu` key codes, following the `winit` update. ([#906])

### Fixed
* Fixed single frame animation ([#781])

This comment has been minimized.

Copy link
@jojolepro

jojolepro Oct 13, 2018

Member

You also need to add a link to the pull request
[#781]: https:......

@jojolepro

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

bors r+
thanks!

bors bot added a commit that referenced this pull request Oct 13, 2018

Merge #1015 #1025
1015: Fixed single frame animation r=jojolepro a=mh84

Fixes #781

1025: Fix denial of warnings r=Moxinilian a=Xaeroxe

Made a boo boo in #1011 , fixing the boo boo now.

Co-authored-by: Marcel Heiber <marcel.heiber@gmx.de>
Co-authored-by: Jacob Kiesel <kieseljake@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

@bors bors bot merged commit e0ed263 into amethyst:master Oct 14, 2018

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.