Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1048. Check debug lines container length #1049

Merged
merged 2 commits into from Oct 21, 2018

Conversation

Projects
None yet
5 participants
@NCrashed
Copy link
Contributor

commented Oct 19, 2018

Fix #1048

Adds additional check in render pass.

NCrashed added some commits Oct 19, 2018

@Rhuagh

Rhuagh approved these changes Oct 19, 2018

@Moxinilian
Copy link
Member

left a comment

Thank you!

@jojolepro
Copy link
Member

left a comment

bors r+
Thanks!

bors bot added a commit that referenced this pull request Oct 19, 2018

Merge #1049
1049: Fix #1048. Check debug lines container length r=jojolepro a=NCrashed

Fix #1048 

Adds additional check in render pass.

Co-authored-by: Anton Gushcha <ncrashed@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2018

@NCrashed

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

Hmm, I actually have no idea why merge build is failed.

@jojolepro

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

bors r+

Because travis breaks all the time

bors bot added a commit that referenced this pull request Oct 19, 2018

Merge #1049
1049: Fix #1048. Check debug lines container length r=jojolepro a=NCrashed

Fix #1048 

Adds additional check in render pass.

Co-authored-by: Anton Gushcha <ncrashed@gmail.com>
@jojolepro

This comment has been minimized.

Copy link
Member

commented Oct 21, 2018

bors r+
REEEEEEEEEEEEEEEEEEEEE

bors bot added a commit that referenced this pull request Oct 21, 2018

Merge #983 #1049
983: Custom aspect ratio for OrthoCamera r=jojolepro a=fuchsnj



1049: Fix #1048. Check debug lines container length r=jojolepro a=NCrashed

Fix #1048 

Adds additional check in render pass.

Co-authored-by: Nathan Fox <fuchsnj@gmail.com>
Co-authored-by: jojo <jojolepromain@gmail.com>
Co-authored-by: Anton Gushcha <ncrashed@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2018

@bors bors bot merged commit afcd748 into amethyst:master Oct 21, 2018

2 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.