This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Add functionality to keep the aspect ratio when stretching a UiTransform #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneKitsune
suggested changes
Mar 25, 2019
Add a new field to the Stretch::XY enum variant that allows for keeping the aspect ratio when stretching.
0x6273
force-pushed
the
ui_stretch_keep_ratio
branch
from
1c84a3b
to
6e359f0
Compare
The x/y_margin values are not ignored, but treated as the minimum amount of margin rather than the absolute amount . More margin will be added to either the horizontal or vertical axis when necessary to keep the aspect ratio. I have changed the doc comment to clarify this. |
bors bot
added a commit
that referenced
this pull request
Mar 26, 2019
1480: Add functionality to keep the aspect ratio when stretching a UiTransform r=jojolepro a=0x6273 ## Description Makes it possible for `UiTransform`s to keep their aspect ratio when stretched to fit their parent. This is a breaking change, because it adds a new field to the `Stretch::XY` struct. ## Modifications - Changed the `Stretch::XY` enum variant struct, adding a new `keep_aspect_ratio` field. - Updated the `UiTransform` system to use this new field when stretching transforms. - Updated all the places where `Stretch::XY` is instantiated, with this new field set to false. ## PR Checklist By placing an x in the boxes I certify that I have: - [x] Ran `cargo test --all` locally if this modified any rs files. - [x] Ran `cargo +stable fmt --all` locally if this modified any rs files. - [x] Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [ ] Added unit tests for new APIs if any were added in this PR. **Not sure how to add a test for this since it involves running a system with entities.** - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. Co-authored-by: 0x40 <0x40@keemail.me>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it possible for
UiTransforms to keep their aspect ratio when stretched to fit their parent.This is a breaking change, because it adds a new field to the
Stretch::XYstruct.Modifications
Stretch::XYenum variant struct, adding a newkeep_aspect_ratiofield.UiTransformsystem to use this new field when stretching transforms.Stretch::XYis instantiated, with this new field set to false.PR Checklist
By placing an x in the boxes I certify that I have:
cargo test --alllocally if this modified any rs files.cargo +stable fmt --alllocally if this modified any rs files.