Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: Only skip invalid meshes, instead of aborting the pass completely. #543
Conversation
| @@ -188,7 +188,7 @@ impl Pass for DrawPbmSeparate { | ||
| { | ||
| match mesh.buffer(attrs) { | ||
| Some(vbuf) => effect.data.vertex_bufs.push(vbuf.clone()), | ||
| - None => return, | ||
| + None => continue 'drawable, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Fixed. |
torkleyy
approved these changes
Jan 16, 2018
We have some code duplication here, but that's obviously not your PR.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
omni-viral
Jan 16, 2018
Member
@torkleyy I wouldn't spend much time to fix minor problems in old renderer.
|
@torkleyy I wouldn't spend much time to fix minor problems in old renderer. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Rhuagh
Jan 16, 2018
Member
Yeah, there's some code duplication, but no good way of removing that without introducing about the same amount of duplication just trying to send data to functions.
|
Yeah, there's some code duplication, but no good way of removing that without introducing about the same amount of duplication just trying to send data to functions. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
bors r+ |
bot
added a commit
that referenced
this pull request
Jan 16, 2018
![@bors[bot]](https://avatars3.githubusercontent.com/in/1847?s=60&v=4){kind=small}
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Timed out |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Overriding |
Xaeroxe
merged commit d3b7d51
into
amethyst:develop
Jan 17, 2018
Rhuagh
deleted the
Rhuagh:fix/renderer-ignore-bad-meshes
branch
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rhuagh commentedJan 15, 2018
•
edited by torkleyy
Edited 1 time
-
torkleyy
edited Jan 15, 2018 (most recent)
This change is