Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor: Move code to minterpolate, and fixing some docs #566
Conversation
Xaeroxe
added
type: improvement
status: ready
project: animation
labels
Feb 9, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Feb 9, 2018
Member
Unfortunately this might need to be rebased again onto develop as bors added a commit prior to merging.
|
Unfortunately this might need to be rebased again onto develop as bors added a commit prior to merging. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
Feb 10, 2018
Member
Reviewed 41 of 46 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.
amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):
} fn map_interpolation_type<T>(ty: &gltf::animation::InterpolationAlgorithm) -> InterpolationFunction<T> where T: InterpolationPrimitive {
Formatting
Comments from Reviewable
|
Reviewed 41 of 46 files at r1, 8 of 8 files at r2. amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):
Formatting Comments from Reviewable |
Rhuagh
added some commits
Feb 9, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rhuagh
Feb 10, 2018
Member
Rebased and fixed formatting.
Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
|
Rebased and fixed formatting. Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rhuagh
Feb 10, 2018
Member
Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.
amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Formatting
Done.
Comments from Reviewable
|
Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion. amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file): Previously, torkleyy (Thomas Schaller) wrote…
Done. Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
Feb 10, 2018
Member
Reviewed 14 of 14 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
|
Reviewed 14 of 14 files at r4. Comments from Reviewable |
Rhuagh commentedFeb 9, 2018
•
edited
Edited 1 time
-
Rhuagh
edited Feb 9, 2018 (most recent)
This has been rebased onto #563.
This change is