New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move code to minterpolate, and fixing some docs #566

Merged
merged 2 commits into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@Rhuagh
Member

Rhuagh commented Feb 9, 2018

This has been rebased onto #563.


This change is Reviewable

@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Feb 9, 2018

Member

Unfortunately this might need to be rebased again onto develop as bors added a commit prior to merging.

Member

Xaeroxe commented Feb 9, 2018

Unfortunately this might need to be rebased again onto develop as bors added a commit prior to merging.

@torkleyy

This comment has been minimized.

Show comment
Hide comment
@torkleyy

torkleyy Feb 10, 2018

Member

Reviewed 41 of 46 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):

}

fn map_interpolation_type<T>(ty: &gltf::animation::InterpolationAlgorithm) -> InterpolationFunction<T> where T: InterpolationPrimitive {

Formatting


Comments from Reviewable

Member

torkleyy commented Feb 10, 2018

Reviewed 41 of 46 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):

}

fn map_interpolation_type<T>(ty: &gltf::animation::InterpolationAlgorithm) -> InterpolationFunction<T> where T: InterpolationPrimitive {

Formatting


Comments from Reviewable

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 10, 2018

Member

Rebased and fixed formatting.


Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

Member

Rhuagh commented Feb 10, 2018

Rebased and fixed formatting.


Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 10, 2018

Member

Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.


amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Formatting

Done.


Comments from Reviewable

Member

Rhuagh commented Feb 10, 2018

Review status: 4 of 18 files reviewed at latest revision, 1 unresolved discussion.


amethyst_gltf/src/format/mod.rs, line 247 at r2 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Formatting

Done.


Comments from Reviewable

@torkleyy

This comment has been minimized.

Show comment
Hide comment
@torkleyy

torkleyy Feb 10, 2018

Member

Reviewed 14 of 14 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

torkleyy commented Feb 10, 2018

Reviewed 14 of 14 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Xaeroxe

LGTM!

bors r+

bors bot added a commit that referenced this pull request Feb 10, 2018

Merge #566
566: refactor: Move code to minterpolate, and fixing some docs r=Xaeroxe a=Rhuagh

This has been rebased onto #563.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/566)
<!-- Reviewable:end -->
@bors

This comment has been minimized.

Show comment
Hide comment

@bors bors bot merged commit 2f1af6e into amethyst:develop Feb 10, 2018

4 checks passed

bors Build succeeded
code-review/reviewable 18 files reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:feature/move-code branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment