New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rate control to animation system #567

Merged
merged 1 commit into from Feb 11, 2018

Conversation

Projects
None yet
3 participants
@Rhuagh
Member

Rhuagh commented Feb 10, 2018


This change is Reviewable

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 11, 2018

Member

Rebased, and ready.

Member

Rhuagh commented Feb 11, 2018

Rebased, and ready.

@torkleyy

This comment has been minimized.

Show comment
Hide comment
@torkleyy

torkleyy Feb 11, 2018

Member

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

            .values_mut()
            .filter(|t| t.state != ControlState::Done)
        {

Can use for_each


Comments from Reviewable

Member

torkleyy commented Feb 11, 2018

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

            .values_mut()
            .filter(|t| t.state != ControlState::Done)
        {

Can use for_each


Comments from Reviewable

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 11, 2018

Member

Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Can use for_each

Done.


Comments from Reviewable

Member

Rhuagh commented Feb 11, 2018

Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.


amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Can use for_each

Done.


Comments from Reviewable

@Xaeroxe

LGTM!

@torkleyy

This comment has been minimized.

Show comment
Hide comment
@torkleyy

torkleyy Feb 11, 2018

Member

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

torkleyy commented Feb 11, 2018

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@torkleyy

Ready to merge in a couple of hours when everybody had the chance to review.

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 11, 2018

Member

bors r+

Member

Rhuagh commented Feb 11, 2018

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2018

Merge #567
567:  feat: Add rate control to animation system r=Rhuagh a=Rhuagh


<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/567)
<!-- Reviewable:end -->
@bors

This comment has been minimized.

Show comment
Hide comment

@bors bors bot merged commit 6993d09 into amethyst:develop Feb 11, 2018

4 checks passed

bors Build succeeded
code-review/reviewable 8 files reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:feature/animation-rate-multiplier branch Feb 11, 2018

bors bot added a commit that referenced this pull request Feb 13, 2018

Merge #569
569:  feat: Add stepping and exact input value control to animation system r=Xaeroxe a=Rhuagh

Needs rebase when #567 is merged.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/569)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment