Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: Add rate control to animation system #567
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Rebased, and ready. |
Rhuagh
added
status: ready
project: animation
labels
Feb 11, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
Feb 11, 2018
Member
Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.
amethyst_animation/src/resources.rs, line 228 at r1 (raw file):
.values_mut() .filter(|t| t.state != ControlState::Done) {
Can use for_each
Comments from Reviewable
|
Reviewed 8 of 8 files at r1. amethyst_animation/src/resources.rs, line 228 at r1 (raw file):
Can use Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rhuagh
Feb 11, 2018
Member
Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.
amethyst_animation/src/resources.rs, line 228 at r1 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Can use
for_each
Done.
Comments from Reviewable
|
Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion. amethyst_animation/src/resources.rs, line 228 at r1 (raw file): Previously, torkleyy (Thomas Schaller) wrote…
Done. Comments from Reviewable |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
Feb 11, 2018
Member
Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
torkleyy
approved these changes
Feb 11, 2018
Ready to merge in a couple of hours when everybody had the chance to review.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
bors r+ |
Rhuagh commentedFeb 10, 2018
•
edited
Edited 2 times
-
Rhuagh
edited Feb 11, 2018 (most recent)
-
torkleyy
edited Feb 10, 2018
This change is