Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

feat: Add rate control to animation system #567

Merged
merged 1 commit into from Feb 11, 2018
Merged

feat: Add rate control to animation system #567

merged 1 commit into from Feb 11, 2018

Conversation

Rhuagh
Copy link
Member

@Rhuagh Rhuagh commented Feb 10, 2018 •
edited

This change is Reviewable

@Rhuagh Rhuagh force-pushed the feature/animation-rate-multiplier branch from d51bd2d to 525289e Compare February 11, 2018 10:04
@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 11, 2018

Rebased, and ready.

@torkleyy
Copy link
Member

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

            .values_mut()
            .filter(|t| t.state != ControlState::Done)
        {

Can use for_each

Comments from Reviewable

@Rhuagh Rhuagh force-pushed the feature/animation-rate-multiplier branch from 525289e to 6993d09 Compare February 11, 2018 11:27
@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 11, 2018

Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion.

amethyst_animation/src/resources.rs, line 228 at r1 (raw file):

Previously, torkleyy (Thomas Schaller) wrote…

Can use for_each

Done.

Comments from Reviewable

Xaeroxe
Xaeroxe approved these changes Feb 11, 2018
View reviewed changes
Copy link
Member

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@torkleyy
Copy link
Member

:lgtm:

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

torkleyy
torkleyy approved these changes Feb 11, 2018
View reviewed changes
Copy link
Member

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge in a couple of hours when everybody had the chance to review.

@Rhuagh
Copy link
Member Author

Rhuagh commented Feb 11, 2018

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2018
@bors
Merge #567
1920143 
567:  feat: Add rate control to animation system r=Rhuagh a=Rhuagh


<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/567)
<!-- Reviewable:end -->
@Rhuagh Rhuagh mentioned this pull request Feb 11, 2018
Merged
@bors
Copy link
Contributor

bors bot commented Feb 11, 2018

Build succeeded

@bors bors bot merged commit 6993d09 into amethyst:develop Feb 11, 2018
@Rhuagh Rhuagh deleted the feature/animation-rate-multiplier branch February 11, 2018 22:47
bors bot added a commit that referenced this pull request Feb 13, 2018
@bors
Merge #569
7845ffc 
569:  feat: Add stepping and exact input value control to animation system r=Xaeroxe a=Rhuagh

Needs rebase when #567 is merged.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/569)
<!-- Reviewable:end -->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xaeroxe Xaeroxe Xaeroxe approved these changes

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rhuagh @torkleyy @Xaeroxe