/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gfx_glyph to newest version #572

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @Xaeroxe @jojolepro @torkleyy
@Rhuagh
Member

Rhuagh commented Feb 14, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Feb 14, 2018 (most recent)

This change is Reviewable
@Rhuagh
fix: Update gfx_glyph
Loading status checks…
4ed8b4e
@Xaeroxe

Xaeroxe approved these changes Feb 14, 2018
View changes

LGTM!

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 14, 2018

Member

Wow, time limit exceeded on Travis..
Member

Rhuagh commented Feb 14, 2018

Wow, time limit exceeded on Travis..
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Feb 14, 2018

Member

Seems spurious. I've restarted the build.
Member

Xaeroxe commented Feb 14, 2018

Seems spurious. I've restarted the build.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 15, 2018

Member

Bors r+
Member

Rhuagh commented Feb 15, 2018

Bors r+

bors bot added a commit that referenced this pull request Feb 15, 2018

@bors[bot]
Merge #572 
572: fix: Update gfx_glyph to newest version r=Rhuagh a=Rhuagh



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/572)
<!-- Reviewable:end -->
Loading status checks…
486a621
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Feb 15, 2018

Contributor

Build failed
Contributor

bors bot commented Feb 15, 2018

Build failed
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 15, 2018

Member

bors r+
Member

Rhuagh commented Feb 15, 2018

bors r+

bors bot added a commit that referenced this pull request Feb 15, 2018

@bors[bot]
Merge #572 
572: fix: Update gfx_glyph to newest version r=Rhuagh a=Rhuagh



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/572)
<!-- Reviewable:end -->
Loading status checks…
2fa7300
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Feb 15, 2018

Contributor

Build succeeded
Contributor

bors bot commented Feb 15, 2018

Build succeeded

@bors bors bot merged commit 4ed8b4e into amethyst:develop Feb 15, 2018
3 checks passed

3 checks passed

bors Build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:fix/update-glyph branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment