/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose types needed to enable transparency in core passes #584

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @Xaeroxe @jojolepro @torkleyy
@Rhuagh
Member

Rhuagh commented Feb 26, 2018 •
edited
Edited 2 times
  • @Rhuagh Rhuagh edited Feb 26, 2018 (most recent)
  • @torkleyy torkleyy edited Feb 26, 2018

Fixes #583.

This change is Reviewable
@torkleyy

torkleyy approved these changes Feb 26, 2018
View changes

This will be rather temporary I assume?

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Feb 26, 2018

Member

Yes, we need to rewrite the core passes for hal anyways.
Member

Rhuagh commented Feb 26, 2018

Yes, we need to rewrite the core passes for hal anyways.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Mar 5, 2018

Member

bors r+
Member

Rhuagh commented Mar 5, 2018

bors r+

bors bot added a commit that referenced this pull request Mar 5, 2018

@bors[bot]
Merge #584 
584: fix: Expose types needed to enable transparency in core passes r=Rhuagh a=Rhuagh

Fixes #583.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/584)
<!-- Reviewable:end -->
Loading status checks…
e07b5c5
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Mar 5, 2018

Contributor

Build failed
Contributor

bors bot commented Mar 5, 2018

Build failed
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Mar 5, 2018

Member

No space left on device.

bors r+
Member

Rhuagh commented Mar 5, 2018 •
edited
Edited 1 time
  • @Rhuagh Rhuagh edited Mar 5, 2018 (most recent)

No space left on device.

bors r+

bors bot added a commit that referenced this pull request Mar 5, 2018

@bors[bot]
Merge #584 
584: fix: Expose types needed to enable transparency in core passes r=Rhuagh a=Rhuagh

Fixes #583.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/584)
<!-- Reviewable:end -->
Loading status checks…
a1f25fb
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Mar 5, 2018

Contributor

Build failed
Contributor

bors bot commented Mar 5, 2018

Build failed
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Mar 5, 2018

Member

Cache deleted, let's try again

bors r=@Rhuagh
Member

Xaeroxe commented Mar 5, 2018

Cache deleted, let's try again

bors r=@Rhuagh

bors bot added a commit that referenced this pull request Mar 5, 2018

@bors[bot]
Merge #584 
584: fix: Expose types needed to enable transparency in core passes r=Rhuagh a=Rhuagh

Fixes #583.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/584)
<!-- Reviewable:end -->
Loading status checks…
94c67c0
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Mar 5, 2018

Contributor

Build succeeded
Contributor

bors bot commented Mar 5, 2018

Build succeeded

@bors bors bot merged commit fae286a into amethyst:develop Mar 5, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:fix/expose-transparency-settings branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment