/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update winit+glutin+gfx_window_* #648

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @jojolepro @Hittherhod @Xaeroxe
@Rhuagh
Member

Rhuagh commented Apr 16, 2018 •
edited
Edited 2 times
  • @Rhuagh Rhuagh edited Apr 17, 2018 (most recent)
  • @torkleyy torkleyy edited Apr 16, 2018

Fixes #544.

This change is Reviewable
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 16, 2018

Collaborator

I'd like a confirmation from @Hittherhod that this fixes #547
Collaborator

jojolepro commented Apr 16, 2018

I'd like a confirmation from @Hittherhod that this fixes #547
@Hittherhod

This comment has been minimized.

Show comment
Hide comment
@Hittherhod

Hittherhod Apr 17, 2018

Contributor

@Rhuagh @jojolepro Nope. I'm still seeing issues upon resizing the pong example.
screen shot 2018-04-16 at 20 49 21
Contributor

Hittherhod commented Apr 17, 2018

@Rhuagh @jojolepro Nope. I'm still seeing issues upon resizing the pong example.
screen shot 2018-04-16 at 20 49 21
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 17, 2018

Member

So it's not fixing that issue then, got it.
Member

Rhuagh commented Apr 17, 2018

So it's not fixing that issue then, got it.
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 17, 2018

Member

bors r+
Member

Xaeroxe commented Apr 17, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 17, 2018

@bors[bot] @Rhuagh
Merge #641 #648 
641: feat: Add texture animation r=Xaeroxe a=Rhuagh

Supports swapping textures (using indexing into a `MaterialTextureSet` resource) and modifying offset into a texture.
The PR also adds support for targeting parts of a texture, using a `Material` defined offset.

Material only support the `Step` interpolation function, all other functions will result in a panic (except possibly a user supplied function).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/641)
<!-- Reviewable:end -->


648: fix: Update winit+glutin+gfx_window_* r=Xaeroxe a=Rhuagh

Fixes #544. 

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/648)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
69f6084
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 17, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 17, 2018

Build succeeded

@bors bors bot merged commit 5786dfb into amethyst:develop Apr 17, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:fix/winit-update branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment