/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/new specs #662

Merged
merged 5 commits into from Apr 25, 2018

Conversation

Reviewers

@Xaeroxe Xaeroxe

@jojolepro jojolepro

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@Rhuagh @Xaeroxe @jojolepro
@Rhuagh
Member

Rhuagh commented Apr 23, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 23, 2018 (most recent)

This change is Reviewable

@Rhuagh Rhuagh added the status: working label Apr 23, 2018

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 23, 2018

Member

First pass done, feedback given on specs. Will wait for new alpha of that before doing the next pass.
Member

Rhuagh commented Apr 23, 2018

First pass done, feedback given on specs. Will wait for new alpha of that before doing the next pass.
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 23, 2018

Member

109 changed files

0_o Thanks for doing this!
Member

Xaeroxe commented Apr 23, 2018

109 changed files

0_o Thanks for doing this!
@Xaeroxe

Xaeroxe approved these changes Apr 23, 2018
View changes

LGTM! Thanks!

@Xaeroxe Xaeroxe requested a review from jojolepro Apr 23, 2018

@jojolepro

jojolepro approved these changes Apr 24, 2018
View changes

You are a legend!
I reviewed the code and everything seems fine, though I didn't go into details to check if all the algorithms were still working.

warning: struct is never used: PongBundle
--> examples/appendix_a/config.rs:79:1

Doc-tests amethyst_renderer

running 1 test
test src/pipe/mod.rs - pipe (line 5) ... ignored
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

ui example works
pong works

book/src/pong_tutorial/pong_tutorial_02.md
@@ -40,7 +40,7 @@ statements to make it through this chapter:
```rust,ignore

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 24, 2018

Collaborator

offtopic: why is it ignore?
@jojolepro

jojolepro Apr 24, 2018

Collaborator

offtopic: why is it ignore?

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 24, 2018

Member

Dunno
@Rhuagh

Rhuagh Apr 24, 2018

Member

Dunno

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 24, 2018

Member

Otherwise mdbook would try and compile this block, when really it lacks the context necessary to be treated as a complete program.
@Xaeroxe

Xaeroxe Apr 24, 2018

Member

Otherwise mdbook would try and compile this block, when really it lacks the context necessary to be treated as a complete program.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 24, 2018

Member

That warning have been there for a while. I can fix it in the next pass.
Member

Rhuagh commented Apr 24, 2018

That warning have been there for a while. I can fix it in the next pass.

@Rhuagh Rhuagh added type: improvement diff: medium pri: important status: ready and removed status: working labels Apr 24, 2018

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 25, 2018

Member

R? @Xaeroxe @jojolepro
Member

Rhuagh commented Apr 25, 2018

R? @Xaeroxe @jojolepro
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 25, 2018

Collaborator

I need to review again?
What changed except the rayon update?
Collaborator

jojolepro commented Apr 25, 2018

I need to review again?
What changed except the rayon update?
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 25, 2018

Member

Can we push this now?
Member

Rhuagh commented Apr 25, 2018

Can we push this now?
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 25, 2018

Member

bors r+
Member

Xaeroxe commented Apr 25, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 25, 2018

@bors[bot] @Rhuagh
Merge #662 
662: Refactor/new specs r=Xaeroxe a=Rhuagh



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/662)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
e4d30b5
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 25, 2018

Collaborator

I'll cry when I try to update my network PR, but yes.

bors r+
Collaborator

jojolepro commented Apr 25, 2018

I'll cry when I try to update my network PR, but yes.

bors r+
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 25, 2018

Contributor

Not awaiting review
Contributor

bors bot commented Apr 25, 2018

Not awaiting review
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 25, 2018

Collaborator

I should have refreshed the page before doing that :P
Collaborator

jojolepro commented Apr 25, 2018

I should have refreshed the page before doing that :P
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 25, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 25, 2018

Build succeeded

@bors bors bot merged commit d751d1a into amethyst:develop Apr 25, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:refactor/new-specs branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment