/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to specs alpha4 #674

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Reviewers

@jojolepro jojolepro

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@Xaeroxe @Rhuagh @torkleyy @jojolepro
@Xaeroxe
Member

Xaeroxe commented Apr 26, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 26, 2018 (most recent)

alpha4 is being treated as a patch version, so this will need to merge as soon as it compiles on CI. Until we do this every build of the develop branch is going to fail.

This change is Reviewable

@Xaeroxe Xaeroxe added type: bug pri: critical project: meta status: ready labels Apr 26, 2018

@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 26, 2018

Member

bors r+
Member

Xaeroxe commented Apr 26, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 26, 2018

@bors[bot] @Xaeroxe
Merge #674 
674: Upgrade to specs alpha4 r=Xaeroxe a=Xaeroxe

alpha4 is being treated as a patch version, so this will need to merge as soon as it compiles on CI.  Until we do this every build of the develop branch is going to fail.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/674)
<!-- Reviewable:end -->


Co-authored-by: Jacob Kiesel <kieseljake@gmail.com>
Loading status checks…
315296e
@Xaeroxe
Upgrade to specs alpha4
Loading status checks…
044d162
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 26, 2018

Member

Aha, I'll need to fix my incoming pr then because I did this in there :)
Member

Rhuagh commented Apr 26, 2018

Aha, I'll need to fix my incoming pr then because I did this in there :)
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 26, 2018

Member

@Rhuagh woops, sorry :P
Member

Xaeroxe commented Apr 26, 2018

@Rhuagh woops, sorry :P
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 26, 2018

Member

No worries, fix the compile issue. I'm waiting for my current pr to be approved anyways :)
Member

Rhuagh commented Apr 26, 2018

No worries, fix the compile issue. I'm waiting for my current pr to be approved anyways :)
@torkleyy

This comment has been minimized.

Show comment
Hide comment
@torkleyy

torkleyy Apr 26, 2018

Member
Member

torkleyy commented Apr 26, 2018

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 26, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 26, 2018

Build succeeded

@bors bors bot merged commit 044d162 into amethyst:develop Apr 26, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Xaeroxe Xaeroxe deleted the Xaeroxe:specs branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment