/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make bundles only contain systems #675

Merged
merged 2 commits into from Apr 28, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @jojolepro @Xaeroxe @torkleyy
@Rhuagh
Member

Rhuagh commented Apr 27, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 27, 2018 (most recent)

This change is Reviewable
examples/animation/main.rs
@@ -282,7 +282,7 @@ fn initialise_sphere(world: &mut World) -> Entity {
/*let mut nodes = HashMap::default();

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 27, 2018

Collaborator

Why is there commented code in the repo?
@jojolepro

jojolepro Apr 27, 2018

Collaborator

Why is there commented code in the repo?

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 27, 2018

Member

No idea, I can remove it
@Rhuagh

Rhuagh Apr 27, 2018

Member

No idea, I can remove it
@torkleyy

torkleyy approved these changes Apr 27, 2018
View changes

Nice!

@Xaeroxe

Xaeroxe approved these changes Apr 27, 2018
View changes

Thanks!

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 28, 2018

Member

Ready.
Member

Rhuagh commented Apr 28, 2018

Ready.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 28, 2018

Member

I can no longer build amethyst on my mac, so I will run it through CI for checking.
Member

Rhuagh commented Apr 28, 2018

I can no longer build amethyst on my mac, so I will run it through CI for checking.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 28, 2018

Member

bors r+
Member

Rhuagh commented Apr 28, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 28, 2018

@bors[bot] @Rhuagh
Merge #675 
675: refactor: Make bundles only contain systems r=Rhuagh a=Rhuagh



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/675)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
b24355d
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 28, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 28, 2018

Build succeeded

@bors bors bot merged commit c7b58f2 into amethyst:develop Apr 28, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:refactor/bundle-systems-only branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment