/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "rodio" dependency to 0.7 #676

Merged
merged 3 commits into from Apr 27, 2018

Conversation

Reviewers

@Rhuagh Rhuagh

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@frazar @Xaeroxe @Rhuagh @jojolepro @torkleyy
@frazar
Contributor

frazar commented Apr 27, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 27, 2018 (most recent)

The latest rodio version introduces some changes in the API naming conventions. However, the changes are minimal and do not affect any public field or struct.

This change is Reviewable
@Rhuagh

Rhuagh approved these changes Apr 27, 2018
View changes

Cool, I'd been planning to do this! :)
LGTM!

@torkleyy

torkleyy approved these changes Apr 27, 2018
View changes

Thanks!

@torkleyy torkleyy added type: improvement project: audio status: ready labels Apr 27, 2018

@Xaeroxe

Xaeroxe approved these changes Apr 27, 2018
View changes

LGTM, since we have three other approvals and I'm the original author of the audio code I feel fine doing this even though it hasn't been 24 hours.

bors r+

bors bot added a commit that referenced this pull request Apr 27, 2018

@bors[bot] @frazar
Merge #676 
676: Update "rodio" dependency to 0.7 r=Xaeroxe a=frazar

The latest `rodio` version introduces some changes in the API naming conventions. However, the changes are minimal and do not affect any `pub`lic field or struct.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/676)
<!-- Reviewable:end -->


Co-authored-by: Francesco Zardi <frazar0@hotmail.it>
Loading status checks…
5fb6d7b
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 27, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 27, 2018

Build succeeded

@bors bors bot merged commit e7435a1 into amethyst:develop Apr 27, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Xaeroxe

This comment has been minimized.

Show comment
Hide comment
@Xaeroxe

Xaeroxe Apr 27, 2018

Member

Congrats on your first PR @frazar ! Thanks for your contribution!
Member

Xaeroxe commented Apr 27, 2018

Congrats on your first PR @frazar ! Thanks for your contribution!
@frazar

This comment has been minimized.

Show comment
Hide comment
@frazar

frazar Apr 28, 2018

Contributor

Thank you for your support! I look forward to contributing more.
Contributor

frazar commented Apr 28, 2018

Thank you for your support! I look forward to contributing more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment