/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Background music did not work because of a incorrectly setup Sys… #679

Merged
merged 2 commits into from Apr 30, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @derekdreery @jojolepro @Xaeroxe
@Rhuagh
Member

Rhuagh commented Apr 28, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 28, 2018 (most recent)

…temData

This change is Reviewable

@Rhuagh Rhuagh added type: bug project: audio status: ready labels Apr 28, 2018

@Rhuagh Rhuagh requested a review from Xaeroxe Apr 28, 2018

@Xaeroxe

Xaeroxe approved these changes Apr 28, 2018
View changes

Thanks!

@Rhuagh Rhuagh requested a review from torkleyy Apr 29, 2018

@derekdreery

This comment has been minimized.

Show comment
Hide comment
@derekdreery

derekdreery Apr 29, 2018

Contributor

FWIW this patch fixes the background music issue on my machine (linux) too.
Contributor

derekdreery commented Apr 29, 2018

FWIW this patch fixes the background music issue on my machine (linux) too.
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 30, 2018

Member

@torkleyy review addressed.
Member

Rhuagh commented Apr 30, 2018

@torkleyy review addressed.
@jojolepro

jojolepro approved these changes Apr 30, 2018
View changes

Thanks!

Btw formatting changes are annoying as hell.

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 30, 2018

Member

Yep, I think some of us are still using rustfmt-nightly. We should be using stable rust fmt preview.
Member

Rhuagh commented Apr 30, 2018

Yep, I think some of us are still using rustfmt-nightly. We should be using stable rust fmt preview.
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 30, 2018

Collaborator

Currently using

rustup component add rustfmt-preview
Collaborator

jojolepro commented Apr 30, 2018

Currently using

rustup component add rustfmt-preview
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 30, 2018

Member

Bors r=Xaeroxe,jojolepro
Member

Rhuagh commented Apr 30, 2018

Bors r=Xaeroxe,jojolepro

bors bot added a commit that referenced this pull request Apr 30, 2018

@bors[bot] @Rhuagh
Merge #679 
679: fix: Background music did not work because of a incorrectly setup Sys… r=Xaeroxe,jojolepro a=Rhuagh

…temData

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/679)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
6df2e82
@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh Apr 30, 2018

Member

I think it's some of our newer contributors :)
Member

Rhuagh commented Apr 30, 2018

I think it's some of our newer contributors :)
@derekdreery

This comment has been minimized.

Show comment
Hide comment
@derekdreery

derekdreery Apr 30, 2018

Contributor

Could rustfmt be put onto the CI? I think there is a switch that makes it issue non-zero exit code if it would have made changes.
Contributor

derekdreery commented Apr 30, 2018

Could rustfmt be put onto the CI? I think there is a switch that makes it issue non-zero exit code if it would have made changes.
@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 30, 2018

Collaborator

We already had a discussion on it and it was mostly a "no", because it makes it harder to create PR and to get them merged.
Collaborator

jojolepro commented Apr 30, 2018

We already had a discussion on it and it was mostly a "no", because it makes it harder to create PR and to get them merged.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 30, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 30, 2018

Build succeeded

@bors bors bot merged commit 1f704be into amethyst:develop Apr 30, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:fix/dj-system-fail branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment