/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update specs after critical bugfix #683

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@Rhuagh @jojolepro @Xaeroxe
@Rhuagh
Member

Rhuagh commented Apr 30, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited Apr 30, 2018 (most recent)

Fixes all issues with entity components not being removed correctly when the entities are removed.

This change is Reviewable

@Rhuagh Rhuagh added type: bug pri: critical project: meta status: ready project: core labels Apr 30, 2018

@Rhuagh Rhuagh requested review from Xaeroxe and jojolepro Apr 30, 2018

@Xaeroxe

Xaeroxe approved these changes Apr 30, 2018
View changes

LGTM! Thanks!

@jojolepro

This comment has been minimized.

Show comment
Hide comment
@jojolepro

jojolepro Apr 30, 2018

Collaborator

bors r+
Collaborator

jojolepro commented Apr 30, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 30, 2018

@bors[bot] @Rhuagh
Merge #683 
683: fix: Update specs after critical bugfix r=jojolepro a=Rhuagh

Fixes all issues with entity components not being removed correctly when the entities are removed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/683)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
db34000
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot Apr 30, 2018

Contributor

Build succeeded
Contributor

bors bot commented Apr 30, 2018

Build succeeded

@bors bors bot merged commit 4c22579 into amethyst:develop Apr 30, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:fix/specs-bugfix branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment