/amethyst

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nightly feature, currently only enables nightly on shred #689

Merged
merged 2 commits into from May 2, 2018

Conversation

Reviewers

@jojolepro jojolepro

@Xaeroxe Xaeroxe

@torkleyy torkleyy

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@Rhuagh @jojolepro @Xaeroxe @torkleyy
@Rhuagh
Member

Rhuagh commented May 1, 2018 •
edited by torkleyy
Edited 1 time
  • @torkleyy torkleyy edited May 1, 2018 (most recent)

This change is Reviewable

@Rhuagh Rhuagh added type: improvement diff: easy pri: normal project: meta status: ready labels May 1, 2018

@Rhuagh
Update Changelog
Loading status checks…
45e4129
@Xaeroxe

Xaeroxe approved these changes May 1, 2018
View changes

Thanks!

@Rhuagh

This comment has been minimized.

Show comment
Hide comment
@Rhuagh

Rhuagh May 2, 2018

Member

bors r=Xaeroxe,jojolepro
Member

Rhuagh commented May 2, 2018

bors r=Xaeroxe,jojolepro

bors bot added a commit that referenced this pull request May 2, 2018

@bors[bot] @Rhuagh
Merge #689 
689: feat: Add nightly feature, currently only enables nightly on shred r=Xaeroxe,jojolepro a=Rhuagh



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/689)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
Loading status checks…
6491cd4
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors bot May 2, 2018

Contributor

Build succeeded
Contributor

bors bot commented May 2, 2018

Build succeeded

@bors bors bot merged commit 45e4129 into amethyst:develop May 2, 2018
3 checks passed

3 checks passed

bors Build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rhuagh Rhuagh deleted the Rhuagh:feature/nightly branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment