New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate REXPaint parser to its own crate #234
Comments
Not a bad idea, and shouldn't be too hard to implement. I had it as part of terminal before because it was heavily derived from https://gitlab.com/medusacle/rs-rexpaint (the licenses are compatible and the original is credited), but with a few tweaks. Thinking about it, since it's already gated by a feature flag this should be a pretty easy one. I'll see what I can come up with. |
I'll work on this in the rex-crate branch: https://github.com/amethyst/bracket-lib/tree/rex-crate |
…and REX loading/saving/color into bracket-rex crate. Passes all local unit testing and examples run, will need integration testing with Hands-on Rust and Roguelike Tutorial.
I don't have time to finish integration testing today, so I'll try and get to that soon. I had to also break out the embedding support into a crate, so it could be used by both rex and bracket-terminal - but I kinda like that, because it's been stable/unchanged for a long time, and cleans up the macro mess in I don't think this will break anything important, but I'm not going to merge it until I've checked. :-) |
Ok, I have it running the Hands-on Rust examples (including the wasm embedded version) and the Roguelike Tutorial. So I think I'm ready to merge this. |
* #234 : Big commit. Separates embedding into bracket-embedding crate, and REX loading/saving/color into bracket-rex crate. Passes all local unit testing and examples run, will need integration testing with Hands-on Rust and Roguelike Tutorial. * #234 - Add embedding module to rltk exports to fixup roguelike tutorial building. * #234 - Change path to embedding in webgpu
Should the rex parser be separated into its own isolated crate? Given the modular nature of bracket-lib I think it makes sense.
XpFile/Layer/Cell
can easily be separated.And then there's
XpColor
which, if this issue is accepted as desired, might also make more sense to be in its own crate alongside the otherXp*
Thoughts?
The text was updated successfully, but these errors were encountered: